[Ffmpeg-devel] [PATCH] different vorbis extradata handling

[matthieu castet]

Hi,
Nico Sabbi wrote:
> Michael Niedermayer wrote:
> 
>> Hi
>>
>> On Friday 13 May 2005 01:36, Nico Sabbi wrote:
>>  
>>
>>> Michael Niedermayer wrote:
>>>   
>>>
>>>>> +    offset += xiphlacing(&ptr[offset], priv->len[1]);
>>>>>       
>>>>
>>>> looks possibly exploitable if a packet is larger then 64*255= 16320
>>>>     
>>>
>>> what value do you advise?
>>>   
>>
>>
>> len/255 + 64 for example
>>
>> [...]
>>  
>>
> attached is the updated patch
> 
Don't you should falback on the old method if the header is wrong ?
All vorbis saved in nut, ... won't be playable anymore...

Shouldn't you do the same thing for theora ?
And for flac ?


Matthieu