[Ffmpeg-devel] build broken again...

[Jacob Meuser]

On Sun, May 08, 2005 at 12:35:09PM -0400, Rich Felker wrote:
> On Sun, May 08, 2005 at 06:08:08PM +0200, Fran?ois Revol wrote:

> > 
> > OPTFLAGS=-O3 -Wall -Wno-switch -DPIC -fomit-frame-pointer
> > 
> > (with PIC of course)
> 
> PIC does not work, afaik. Stop insisting on using it.

PIC does work, and it is needed some places (ok, not if you don't
use shared libraries, but that is another discussion/flame war).

libavcodec/i386/dsputil_mmx.c has some code that depends on PIC
being defined ~ line 63 (assuming shared libraries), but the
configure option --enable-shared doesn't add -DPIC to CFLAGS.

therefore I suggest the attached patch, so that PIC works, without
having to add -DPIC manually, with the result that people think it
doesn't work, etc.

-- 
<jakemsr at jakemsr.com>
-------------- next part --------------
Index: configure
===================================================================
RCS file: /cvsroot/ffmpeg/ffmpeg/configure,v
retrieving revision 1.175
diff -u -r1.175 configure
--- configure	8 May 2005 15:04:59 -0000	1.175
+++ configure	9 May 2005 09:11:59 -0000
@@ -1317,7 +1317,7 @@
 fi
 if test "$lshared" = "yes" ; then
   echo "BUILD_SHARED=yes" >> config.mak
-  echo "PIC=-fPIC" >> config.mak
+  echo "PIC=-fPIC -DPIC" >> config.mak
 fi
 echo "EXTRALIBS=$extralibs" >> config.mak
 version=`grep '#define FFMPEG_VERSION ' "$source_path/libavcodec/avcodec.h" |