[Ffmpeg-devel] [PATCH]video codec nine bitstream fixes

Michael Niedermayer michaelni
Sun May 8 19:22:22 CEST 2005


Hi

On Sunday 08 May 2005 18:28, Alexander Strasser wrote:
[...]
> >  #if HAS_ADVANCED_PROFILE
> >      if (v->profile == PROFILE_ADVANCED)
> >      {
> >          v->level = get_bits(gb, 3);
> > +	if(v->level >= 9)
> > +	{
> > +	    av_log(avctx, AV_LOG_ERROR, "Reserved LEVEL %i\n");
> > +	}
>
>   Didn't you miss v->level in that av_log call?

not to mention that checking 3 bits >= 9 is a little silly


> Also indentation is a bit messed up, would be nice if you would

the patch is full of tabs ...

[...]
-- 
Michael





More information about the ffmpeg-devel mailing list