[Ffmpeg-devel] Re: [PATH] enable-libgsm not working

[Michel Bardiaux]

Alban Bedel wrote:
> On Thu, 23 Jun 2005 10:21:37 +0200
> Michel Bardiaux <mbardiaux at peaktime.be> wrote:
> 
> 
>>Alban Bedel wrote:
>>
>>>On Wed, 22 Jun 2005 18:04:48 +0200
>>>Michel Bardiaux <mbardiaux at peaktime.be> wrote:
>>>
>>>
>>>
>>>>-#include <gsm.h>
>>>>+#include <gsm/gsm.h>
>>>
>>>
>>>Hmm, are you sure that this is not Debian specific ? 
>>
>>Could be, I dont use any other distro so I cant check. I modelled my 
>>changes on what was already in lavc for mp3lame, and that matched what 
>>happens with debian.
>>
>>
>>>I have libgsm
>>>installed from sources here and i don't have the include in a gsm
>>>subdirectory. In fact checking their makefile it seems there
>>>is no sensible default in there (default to $(GSM_INSTALL_ROOT)/inc
>>>with GSM_INSTALL_ROOT empty).
>>
>>I have gsm from sources too (now switching to distros because libgsm 
>>seems very stable now). gsm.h comes in subdirectory 'inc'. I didnt use 
>>'make install'.
> 
> 
> Neither did I and that the problem. Their default is so broken that we
> can't expect it to be used. It's then perhaps better to tweak configure
> to check both case and add the correct -I if needed. Or blindly add
> -I/usr/include/gsm -I/usr/local/include/gsm ;)
> 
> 	Albeu

No. What is good for mp3lame (and vorbis, and ogg, and theora) should be 
good for libgsm. And a configure that tries to be smart is a recipe for 
disaster (if it werent we would be autotooled all the way...) But since 
the broken stuff is actually the make install in the gsm source distro, 
maybe configure could issue a message to the effect that gsm.h and 
libgsm.so are expected at such-and-such place.

HaND,
-- 
Michel Bardiaux
Peaktime Belgium S.A.  Bd. du Souverain, 191  B-1160 Bruxelles
Tel : +32 2 790.29.41