[Ffmpeg-devel] Bug: Quoted string for <Feed>, <Stream> and <Redirect>

Shigeru Kanemoto sgksgk
Wed Jun 22 08:39:34 CEST 2005


Hi,

Very easy bug. Segmentation violation occurs when I provide quoted
string for <Feed>, <Stream> and <Redirect> directives in the
configuration file.

sgk

-----------------------------------------------------------

diff -c -r1.93 ffserver.c
*** ffserver.c  7 May 2005 00:56:05 -0000       1.93
--- ffserver.c  22 Jun 2005 06:32:59 -0000
***************
*** 3832,3838 ****

                  get_arg(feed->filename, sizeof(feed->filename), &p);
                  q = strrchr(feed->filename, '>');
!                 if (*q)
                      *q = '\0';
                  feed->fmt = guess_format("ffm", NULL, NULL);
                  /* defaut feed file */
--- 3832,3838 ----

                  get_arg(feed->filename, sizeof(feed->filename), &p);
                  q = strrchr(feed->filename, '>');
!                 if (q)
                      *q = '\0';
                  feed->fmt = guess_format("ffm", NULL, NULL);
                  /* defaut feed file */
***************
*** 3932,3938 ****

                  get_arg(stream->filename, sizeof(stream->filename), &p);
                  q = strrchr(stream->filename, '>');
!                 if (*q)
                      *q = '\0';
                  stream->fmt = guess_stream_format(NULL,
stream->filename, NULL);
                  memset(&audio_enc, 0, sizeof(AVCodecContext));
--- 3932,3938 ----

                  get_arg(stream->filename, sizeof(stream->filename), &p);
                  q = strrchr(stream->filename, '>');
!                 if (q)
                      *q = '\0';
                  stream->fmt = guess_stream_format(NULL,
stream->filename, NULL);
                  memset(&audio_enc, 0, sizeof(AVCodecContext));
***************
*** 4326,4332 ****

                  get_arg(redirect->filename, sizeof(redirect->filename), &p);
                  q = strrchr(redirect->filename, '>');
!                 if (*q)
                      *q = '\0';
                  redirect->stream_type = STREAM_TYPE_REDIRECT;
              }
--- 4326,4332 ----

                  get_arg(redirect->filename, sizeof(redirect->filename), &p);
                  q = strrchr(redirect->filename, '>');
!                 if (q)
                      *q = '\0';
                  redirect->stream_type = STREAM_TYPE_REDIRECT;
              }





More information about the ffmpeg-devel mailing list