[Ffmpeg-devel] bash substitutions
Rich Felker
dalias
Sun Dec 18 01:08:56 CET 2005
On Sat, Dec 17, 2005 at 03:28:30PM -0800, Jacob Meuser wrote:
> revision 1.217 of configure added some shell substitutions.
> these apparently only work with bash, which is _not_ the /bin/sh
> on all systems.
>
> specifically:
>
> echo "SPPMAJOR=${lavc_version/.*/}" >> config.mak
> echo "LAVCMAJOR=${lavc_version/.*/}" >> config.mak
> echo "LAVFMAJOR=${lavf_version/.*/}" >> config.mak
> echo "LAVUMAJOR=${lavu_version/.*/}" >> config.mak
>
> this not work with pdksh, which is the /bin/sh on OpenBSD.
> I doubt it works with ash, which is the /bin/sh on NetBSD.
>
> I suggest the following patch.
bashisms must die!!!!!
btw, $() is not safe/proper either. `` should be used instead for full
portability.
rich
More information about the ffmpeg-devel
mailing list