[Ffmpeg-devel] [PATCH] from DivX, Part 7: MSVC fixes
Sat Dec 17 14:43:25 CET 2005
On Saturday 17 December 2005 05:21, Rich Felker wrote:
> On Fri, Dec 16, 2005 at 04:18:02PM -1000, Steve Lhomme wrote:
> > Rich Felker wrote:
> > >On Fri, Dec 16, 2005 at 01:49:16PM -1000, Steve Lhomme wrote:
> > >>These are only the "soft" part of the MSVC fixes. That means I didn't
> > >>include parts I know wouldn't make it, like the named fields in
> > >>structures.
> > >>
> > >>
> > >>- DCTELEM __align8 block;
> > >>+ __align8(DCTELEM, block);
> > >
> > >And this is supposed to be readable how?? It doesn't even look like a
> > >declaration anymore!
> > Tell me in the standard C __align8 is defined. As ffmpeg is supposed to
> _align8 is #defined on gcc to gcc-specific stuff, and defined as empty
> on other compilers. This is perfectly fine since it's only needed for
> the asm, which is only supported on gcc.
How about simply #defining DCTELEM to be either of these, depending on
compiler? then one could allways write
Or perhaps there are cases where the alignment is not needed?
More information about the ffmpeg-devel