[Ffmpeg-devel] [PATCH] from DivX, Part 1: cosmectic changes
Fri Dec 16 21:37:09 CET 2005
Michael Niedermayer wrote:
> On Fri, Dec 16, 2005 at 09:04:10AM +0000, Benjamin Larsson wrote:
>>Most of it looks ok but I think the patch needs one pure cosmetical part
>>and another functional one. And
>>the cosmetical part of the patch needs some work. I looked through the
>>most obvious parts.
> doing tab->space conversation should be a matter of running
> expand | sed 's/ *$//' over the files
> trailing tabs -> trailing whitespace :(
Could someone do that in CVS ? At least that would make my future
patches cleaner. And my job much easier. Unless you can explain me how
to put all the code I want to submit and cut it in 20 "logical" patches.
I'm just a human you know...
>>Not int8_t ?
> hmm, AFAIK sizeof(char) must be 1 so that shouldnt be an issue, but i
> might be wrong
Yes, sizeof(char) has to be 1. But you can use int8_t if you prefer.
>>>@@ -713,8 +713,8 @@
>>> io_buffer_size = 1024;
>>>- if(sizeof(DynBuffer) + io_buffer_size < io_buffer_size)
>>>- return -1;
>>>+ assert(sizeof(DynBuffer) + io_buffer_size >= io_buffer_size);
> such changes are not acceptable
Ah. But this one is the most interresting patch.
Because if you look at the original code. I can't think of any case
where this is true. So I'd better remove it of my Release (no assert)
More information about the ffmpeg-devel