[Ffmpeg-devel] [PATCH] from DivX, Part 1: cosmectic changes

[Michael Niedermayer]

Hi

On Fri, Dec 16, 2005 at 09:04:10AM +0000, Benjamin Larsson wrote:
[...]
> Most of it looks ok but I think the patch needs one pure cosmetical part
> and another functional one. And
> the cosmetical part of the patch needs some work. I looked through the
> most obvious parts.

doing tab->space conversation should be a matter of running
expand | sed 's/ *$//' over the files


> 
> >@@ -820,10 +820,10 @@
> >                     padcolor);
> >         }
> >         
> >-	if (enc->pix_fmt != PIX_FMT_YUV420P) {
> >+        if (enc->pix_fmt != PIX_FMT_YUV420P) {
> >             int size;
> >-	    
> >-	    av_free(buf);
> >+            
> >  
> >
> Tabs -> whitespace.

trailing tabs -> trailing whitespace :(


> 
> >     dvdsub_init_decoder,
> >     NULL,
> >     dvdsub_close_decoder,
> >Index: libavcodec/faac.c
> >===================================================================
> >RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/faac.c,v
> >retrieving revision 1.3
> >diff -u -r1.3 faac.c
> >--- libavcodec/faac.c	21 Aug 2005 20:27:00 -0000	1.3
> >+++ libavcodec/faac.c	15 Dec 2005 01:59:45 -0000
> >Index: libavcodec/loco.c
> >===================================================================
> >RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/loco.c,v
> >retrieving revision 1.5
> >diff -u -r1.5 loco.c
> >--- libavcodec/loco.c	8 Apr 2005 21:34:48 -0000	1.5
> >+++ libavcodec/loco.c	15 Dec 2005 02:06:59 -0000
> >@@ -241,14 +241,14 @@
> >         l->lossy = 0;
> >         break;
> >     case 2:
> >-        l->lossy = LE_32(avctx->extradata + 8);
> >+        l->lossy = LE_32((char*)avctx->extradata + 8);
> >  
> >
> Not int8_t ?

hmm, AFAIK sizeof(char) must be 1 so that shouldnt be an issue, but i
might be wrong


[...]

> >@@ -713,8 +713,8 @@
> >     else
> >         io_buffer_size = 1024;
> >         
> >-    if(sizeof(DynBuffer) + io_buffer_size < io_buffer_size)
> >-        return -1;
> >+    assert(sizeof(DynBuffer) + io_buffer_size >= io_buffer_size);
> >+
> >  
> >
> ?

such changes are not acceptable


[...]
-- 
Michael