[Ffmpeg-devel] RealAudio 14.4

François Revol revol
Sun Dec 11 09:02:20 CET 2005


> This patch should fix the problem with RealAudio 14.4 files.  The
> problem is that not all the headers are guaranteed to be there.  In
> particular the fourcc may not be present in old-style .ra files.
> (I've never seen one of these files with anything but 14.4 in it.)
> We need to pay attention to the total header length and not read more
> bytes than are actually there.
> 
> This should successfully play the thankyou144.ra file that was posted
> earlier.  Please test.
> 
> --- ffmpeg/libavformat/rm.c     9 Dec 2005 16:08:18 -0000       1.50
> +++ ffmpeg/libavformat/rm.c     11 Dec 2005 04:50:34 -0000
> @@ -488,7 +488,7 @@
>  {
>      RMContext *rm = s->priv_data;
>      ByteIOContext *pb = &s->pb;
> -    char buf[128];
> +    char buf[65536];

Are you sure you need 64KB of on-stack buffer there ?
I'm concerned that might be a problem on some embedded platforms...

Fran?ois.






More information about the ffmpeg-devel mailing list