[Ffmpeg-devel] [PATCH] Fix for memleak in dv.c

[Michael Niedermayer]

Hi

On Fri, Aug 26, 2005 at 12:58:19AM +0200, plaum at ipf.uni-stuttgart.de wrote:
> Another one:
> 
> This fixes a memleak (ca. 200 kB) in dv.c by allocating dv_vlc_map
> via av_mallocz_static().
> 
> I also found something scary in dv.c:
> 
> /* MultiThreading */
> static uint8_t** dv_anchor;
> 
> /* .. and a bit later in dvvideo_init()... */
> 
> /* dv_anchor lets each thread know its Id */
> dv_anchor = av_malloc(12*27*sizeof(void*));
> 
> Shouldn't dv_anchor be moved to DVVideoContext?
> I doubt that multiple instances of dv decoders would work with the
> current code.

roman can you explain/fix this?

[...]

> Index: libavcodec/dv.c
> ===================================================================
> RCS file: /cvsroot/ffmpeg/ffmpeg/libavcodec/dv.c,v
> retrieving revision 1.62

patching file dv.c
Hunk #1 FAILED at 109.
Hunk #2 FAILED at 148.
2 out of 2 hunks FAILED -- saving rejects to file dv.c.rej

[...]

-- 
Michael