[Ffmpeg-devel] Patch for outdated bug in output_example.c

[Martin Boehme]

Rich Felker wrote:
> On Mon, Aug 22, 2005 at 09:49:17AM +0200, Martin Boehme wrote:
> 
>>Rich Felker wrote:
>>
>>>On Sun, Aug 21, 2005 at 09:45:47PM +0200, Michael Niedermayer wrote:
>>>
>>>>On Thu, Aug 18, 2005 at 05:28:30PM +0200, Martin Boehme wrote:
>>>>
>>>>
>>>>>This (trivial) patch updates a comment that didn't get changed when 
>>>>>frame_rate changed to time_base.
>>>>>Index: output_example.c
>>>>>===================================================================
>>>>>RCS file: /cvsroot/ffmpeg/ffmpeg/output_example.c,v
>>>>>retrieving revision 1.16
>>>>>diff -u -r1.16 output_example.c
>>>>>--- output_example.c	23 Jul 2005 15:43:07 -0000	1.16
>>>>>+++ output_example.c	18 Aug 2005 15:27:54 -0000
>>>>>@@ -199,7 +199,8 @@
>>>>>   /* resolution must be a multiple of two */
>>>>>   c->width = 352;  
>>>>>   c->height = 288;
>>>>>-    /* frames per second */
>>>>>+    /* time base: This is the interval between two frames in seconds,
>>>>>+     * expressed as a fraction */
>>>>
>>>>this is not correct for "variable fps" video
>>>
>>>Correct description:
>>>time base: this is the fundamental unit of time (in seconds) in terms
>>>of which frame timestamps are represented. for fixed-fps content,
>>>timebase should be 1/framerate and timestamp increments should be
>>>identically 1.
>>
>>Thanks for pointing that out. If it's OK with you, I'll submit a patch 
>>that changes the comment to your wording (and put it into avcodec.h too 
>>while I'm at it).
> 
> Too late, Michael already did it. :)

Cool.

Martin

-- 
Martin B?hme
Inst. f. Neuro- and Bioinformatics
Ratzeburger Allee 160, D-23538 Luebeck
Phone: +49 451 500 5514
Fax:   +49 451 500 5502
boehme at inb.uni-luebeck.de