[Ffmpeg-devel] ogg vorbis encode?

[Alexander Strasser]

Hi,

Michael Niedermayer wrote:
> On Sun, Aug 14, 2005 at 02:28:08PM +0200, Alexander Strasser wrote:
> > Rich Felker wrote:
> > > On Sat, Aug 13, 2005 at 05:53:58PM +0200, Michael Niedermayer wrote:
> > > > vorbis in ogg encoding did work fine in the past, but indeed it seems broken
> > > > currently, i dont know why
> > > 
> > > It's because the encoder was fixed to output its headers as extradata
> > > rather than (incorrectly) as audio frames, but the ogg muxer has not
> > > been fixed to convert them back to packets for the broken ogg header
> > > format.. At least that's my guess.
> > 
> >   I looked into this last night and it seems Rich is right.
> > The encoding of vorbis extra data was changed recently. But
> > the ogg writer wasn't updated and expects the old extradata.
> >   When i extract the vorbis headers from extradata like in
> > vorbis.c (in case of the new extradata encoding) then it seems
> > to work correctly.
> > 
> >   Patch attached, tho i am sure it may not be the best solution.
> 
> if it works, apply it

  Applied. It should work for most `popular' usage.

  As I said it might not work with some files produced by older
versions of libav. We can discuss how to solve this best if it
is necesarry.

  I try to have a deeper look on the weekend.

  Alex (beastd)