[Ffmpeg-devel] ogg vorbis encode?

[Rich Felker]

On Sun, Aug 14, 2005 at 03:17:16PM +0200, Alexander Strasser wrote:
> Alexander Strasser wrote:
> [...]
> > > > vorbis in ogg encoding did work fine in the past, but indeed it seems broken
> > > > currently, i dont know why
> > > 
> > > It's because the encoder was fixed to output its headers as extradata
> > > rather than (incorrectly) as audio frames, but the ogg muxer has not
> > > been fixed to convert them back to packets for the broken ogg header
> > > format.. At least that's my guess.
> > 
> >   I looked into this last night and it seems Rich is right.
> > The encoding of vorbis extra data was changed recently. But
> > the ogg writer wasn't updated and expects the old extradata.
> >   When i extract the vorbis headers from extradata like in
> > vorbis.c (in case of the new extradata encoding) then it seems
> > to work correctly.
> > 
> >   Patch attached, tho i am sure it may not be the best solution.
> 
>   Hmm, it wouldn't work when copying some combinations that
> used the old extradata format for vorbis storage, wouldn't it?

The "old extradata format" is never used, afaik. It was invented by
ffmpeg and just existed for a few weeks.

>   So maybe it is best to support the old and the new format here too?

If anyone insists we could support both, but I don't think it's
necessary.

Rich