[Ffmpeg-devel] liba52/crc.c fails to compile

[Michael Niedermayer]

Hi

On Friday 05 August 2005 23:13, Alexander Strasser wrote:
> Hi,
>
> Steven M. Schultz wrote:
> > gcc -O3 -g -Wall -Wno-switch  -DHAVE_AV_CONFIG_H -I..
> > -I'/usr/local/src/ffmpeg'/libavutil -D_FILE_OFFSET_BITS=64
> > -D_LARGEFILE_SOURCE -D_GNU_SOURCE   -c -o liba52/crc.o liba52/crc.c
> > liba52/crc.c:26:23: ../common.h: No such file or directory
> > liba52/crc.c:28: error: syntax error before "crc_lut"
> >
> > 	Removing the extraneous "../" from common.h seems to be the right
> > 	thing to do since "-I.../libavutil" is in the compiler's search path.
> >
> > 	Trivial patch attached.
> >
> > --- crc.c.dist	2004-06-09 21:28:14.000000000 -0700
> > +++ crc.c	2005-08-02 13:52:04.000000000 -0700
> > @@ -23,7 +23,7 @@
> >
> >  #include <stdlib.h>
> >  #include <stdio.h>
> > -#include "../common.h"
> > +#include "common.h"
> >
> >  static const uint16_t crc_lut[256] =
> >  {
>
>   Should be ok. Though I am not familiar with liba52 in libavcodec
> and to be honest didn't expect it to include common.h from lavc.
>
>   Is common.h included here to get the int types right?

hmm, probably
if so then it should be replaced with <inttypes.h>

[...]
-- 
Michael