[Ffmpeg-devel] Snow segfault bug in revision 1.43

[Guillaume Poirier]

Hi,

On Apr 11, 2005 10:10 PM, Guillaume Poirier <poirierg at gmail.com> wrote:
> Hi,
> 
> On Apr 11, 2005 5:52 AM, Yartrebo <yartrebo at earthlink.net> wrote:
> > On Sun, 2005-04-10 at 22:13 -0400, Yartrebo wrote:
> > > When encoding or decoding 400x300 video, snow revisions 1.43 and onwards
> > > cause a segmentation fault in predict_slice.
> > >
> > > Robert
> > >
> > Bug found, patch attached.
> > Turns out that for heights that are not a multiple of the block height
> > (16), predict_slice writes past the end of the buffer. I've fixed it.
> 
> Tested on AMD-64, no problem.

Well, now I'm not too sure. Your patch adds i386/snow_mmx_sse2.h which
doesn't seem to get included on my build as the build goes though not
matter it's in libavcodec/i386/snow_mmx_sse2.h or
main/i386/snow_mmx_sse2.h (which is the spot where it got created by
"patch" at first.

So I'd say patch not tested on AMD-64... :-(

Guillaume