[FFmpeg-cvslog] fftools/textformat: do not return early

Marvin Scholz git at videolan.org
Fri Jun 27 00:43:18 EEST 2025


ffmpeg | branch: master | Marvin Scholz <epirat07 at gmail.com> | Wed Jun 11 22:33:17 2025 +0200| [5c1e10d9958ea5d3847ad3af3107dd021d7fe29b] | committer: Marvin Scholz

fftools/textformat: do not return early

This would make the goto dead code and also would not properly
call avtext_context_close.

Fix CID 1646939

Reviewed-by: softworkz <softworkz at hotmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5c1e10d9958ea5d3847ad3af3107dd021d7fe29b
---

 fftools/textformat/avtextformat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fftools/textformat/avtextformat.c b/fftools/textformat/avtextformat.c
index fa5abce261..e1aaa9ba57 100644
--- a/fftools/textformat/avtextformat.c
+++ b/fftools/textformat/avtextformat.c
@@ -222,7 +222,6 @@ int avtext_context_open(AVTextFormatContext **ptctx, const AVTextFormatter *form
                 av_log(tctx, AV_LOG_ERROR,
                        "Invalid UTF8 sequence %s found in string validation replace '%s'\n",
                        bp.str, tctx->string_validation_replacement);
-                return ret;
                 goto fail;
             }
         }



More information about the ffmpeg-cvslog mailing list