[FFmpeg-cvslog] fftools: do not access out of bounds filtergraph

Marvin Scholz git at videolan.org
Fri Oct 4 15:28:47 EEST 2024


ffmpeg | branch: master | Marvin Scholz <epirat07 at gmail.com> | Tue Oct  1 02:57:11 2024 +0200| [5beeb3a1f97d8f6d4076fe83aaf5e2e5871f945e] | committer: Marvin Scholz

fftools: do not access out of bounds filtergraph

The log message was logged for `filtergraphs[j]` which would cause a
heap buffer overflow in certain circumstances.

Correctly it should be logged for the current filtergraph, so just
use `fg` here.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5beeb3a1f97d8f6d4076fe83aaf5e2e5871f945e
---

 fftools/ffmpeg_filter.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c
index 2ff7c4c4f4..ddcd18dd15 100644
--- a/fftools/ffmpeg_filter.c
+++ b/fftools/ffmpeg_filter.c
@@ -1409,7 +1409,7 @@ int fg_finalise_bindings(void)
         for (int j = 0; j < fg->nb_outputs; j++) {
             OutputFilter *output = fg->outputs[j];
             if (!output->bound) {
-                av_log(filtergraphs[j], AV_LOG_FATAL,
+                av_log(fg, AV_LOG_FATAL,
                        "Filter %s has an unconnected output\n", output->name);
                 return AVERROR(EINVAL);
             }



More information about the ffmpeg-cvslog mailing list