[FFmpeg-cvslog] fftools/ffplay: fix crash when vk renderer is null

Leandro Santiago git at videolan.org
Wed Nov 6 10:50:10 EET 2024


ffmpeg | branch: master | Leandro Santiago <leandrosansilva at gmail.com> | Thu Oct 31 21:50:45 2024 +0100| [fd0cacc4720c68c58f86e41153444252dbd4e5b6] | committer: Zhao Zhili

fftools/ffplay: fix crash when vk renderer is null

When vulkan rendering is requested by the user and fails, ffplay should
exit graciously instead of crash due to a null pointer deref.

Signed-off-by: Leandro Santiago <leandrosansilva at gmail.com>
Signed-off-by: Zhao Zhili <zhilizhao at tencent.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=fd0cacc4720c68c58f86e41153444252dbd4e5b6
---

 fftools/ffplay.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index a596972769..2a572fc3aa 100644
--- a/fftools/ffplay.c
+++ b/fftools/ffplay.c
@@ -2612,6 +2612,11 @@ static int create_hwaccel(AVBufferRef **device_ctx)
     if (type == AV_HWDEVICE_TYPE_NONE)
         return AVERROR(ENOTSUP);
 
+    if (!vk_renderer) {
+        av_log(NULL, AV_LOG_ERROR, "Vulkan renderer is not available\n");
+        return AVERROR(ENOTSUP);
+    }
+
     ret = vk_renderer_get_hw_dev(vk_renderer, &vk_dev);
     if (ret < 0)
         return ret;



More information about the ffmpeg-cvslog mailing list