[FFmpeg-cvslog] fftools/cmdutils: do not use a random codec's private options

Anton Khirnov git at videolan.org
Thu Mar 28 09:54:39 EET 2024


ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Fri Mar 22 16:41:56 2024 +0100| [2d06a7570e78520a5ba6897d9e0964eb65ab9a8c] | committer: Anton Khirnov

fftools/cmdutils: do not use a random codec's private options

There is only a single caller of filter_codec_opts() that passes
a NULL codec to it, which is streamcopy in ffmpeg CLI. In that case we
only want generic AVCodecContext options, not private options of any
specific encoder.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=2d06a7570e78520a5ba6897d9e0964eb65ab9a8c
---

 fftools/cmdutils.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index f3c258bb99..1bb26f44f4 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -998,10 +998,6 @@ int filter_codec_opts(const AVDictionary *opts, enum AVCodecID codec_id,
     char          prefix = 0;
     const AVClass    *cc = avcodec_get_class();
 
-    if (!codec)
-        codec            = s->oformat ? avcodec_find_encoder(codec_id)
-                                      : avcodec_find_decoder(codec_id);
-
     switch (st->codecpar->codec_type) {
     case AVMEDIA_TYPE_VIDEO:
         prefix  = 'v';



More information about the ffmpeg-cvslog mailing list