[FFmpeg-cvslog] avfilter: update filter timeline state only on main link
Gyan Doshi
git at videolan.org
Mon Mar 11 12:09:15 EET 2024
ffmpeg | branch: master | Gyan Doshi <ffmpeg at gyani.pro> | Fri Mar 1 19:21:52 2024 +0530| [3d1860ec8db7f9785bf1338e826138c0218dfb59] | committer: Gyan Doshi
avfilter: update filter timeline state only on main link
At present, consume_update evaluates timeline state on all links for
a multi-input filter. This can lead to the filter being incorrectly
en/dis-abled when evaluation on a frame on a secondary link leads to
a different result than the frame on the current main link next in
line for processing.
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=3d1860ec8db7f9785bf1338e826138c0218dfb59
---
libavfilter/avfilter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c
index c323ebb4b8..831871de90 100644
--- a/libavfilter/avfilter.c
+++ b/libavfilter/avfilter.c
@@ -1436,7 +1436,8 @@ static void consume_update(FilterLinkInternal *li, const AVFrame *frame)
AVFilterLink *const link = &li->l;
update_link_current_pts(li, frame->pts);
ff_inlink_process_commands(link, frame);
- link->dst->is_disabled = !ff_inlink_evaluate_timeline_at_frame(link, frame);
+ if (link == link->dst->inputs[0])
+ link->dst->is_disabled = !ff_inlink_evaluate_timeline_at_frame(link, frame);
link->frame_count_out++;
link->sample_count_out += frame->nb_samples;
}
More information about the ffmpeg-cvslog
mailing list