[FFmpeg-cvslog] avcodec/lpc: copy levenson coeffs only when they have been computed
Michael Niedermayer
git at videolan.org
Thu Jun 13 23:40:52 EEST 2024
ffmpeg | branch: release/5.1 | Michael Niedermayer <michael at niedermayer.cc> | Sat May 11 20:50:44 2024 +0200| [0a27f1d3318c7204b7d286a7141052162299ba61] | committer: Michael Niedermayer
avcodec/lpc: copy levenson coeffs only when they have been computed
Fixes: CID1473514 Uninitialized scalar variable
Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit c2d897f3566fdf5c190583c6f5197ead5abec2ed)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=0a27f1d3318c7204b7d286a7141052162299ba61
---
libavcodec/lpc.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c
index 3238ad5fc8..66f7a745f7 100644
--- a/libavcodec/lpc.c
+++ b/libavcodec/lpc.c
@@ -244,8 +244,10 @@ int ff_lpc_calc_coefs(LPCContext *s,
double av_uninit(weight);
memset(var, 0, FFALIGN(MAX_LPC_ORDER+1,4)*sizeof(*var));
- for(j=0; j<max_order; j++)
- m[0].coeff[max_order-1][j] = -lpc[max_order-1][j];
+ /* Avoids initializing with an unused value when lpc_passes == 1 */
+ if (lpc_passes > 1)
+ for(j=0; j<max_order; j++)
+ m[0].coeff[max_order-1][j] = -lpc[max_order-1][j];
for(; pass<lpc_passes; pass++){
avpriv_init_lls(&m[pass&1], max_order);
More information about the ffmpeg-cvslog
mailing list