[FFmpeg-cvslog] avcodec/dxv: Fix type in get_opcodes()

Michael Niedermayer git at videolan.org
Wed Jul 24 17:49:47 EEST 2024


ffmpeg | branch: release/4.3 | Michael Niedermayer <michael at niedermayer.cc> | Fri Jul  5 02:21:44 2024 +0200| [55f4161005596dfa7e9934b6dceaf6f8fe3d4f3a] | committer: Michael Niedermayer

avcodec/dxv: Fix type in get_opcodes()

Found by code review related to CID1604386 Overflowed constant

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit e5af1c6e91e86b184101ef2abb49178ff409703b)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=55f4161005596dfa7e9934b6dceaf6f8fe3d4f3a
---

 libavcodec/dxv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c
index 71d85208d8..69263cd30d 100644
--- a/libavcodec/dxv.c
+++ b/libavcodec/dxv.c
@@ -440,7 +440,7 @@ static int get_opcodes(GetByteContext *gb, uint32_t *table, uint8_t *dst, int op
 
     size_in_bits = bytestream2_get_le32(gb);
     endoffset = ((size_in_bits + 7) >> 3) - 4;
-    if (endoffset <= 0 || bytestream2_get_bytes_left(gb) < endoffset)
+    if ((int)endoffset <= 0 || bytestream2_get_bytes_left(gb) < endoffset)
         return AVERROR_INVALIDDATA;
 
     offset = endoffset;



More information about the ffmpeg-cvslog mailing list