[FFmpeg-cvslog] avdevice/dshow: Remove NULL check on pin

Michael Niedermayer git at videolan.org
Mon Jul 15 03:01:48 EEST 2024


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Mon May 27 01:52:22 2024 +0200| [989e11acb65e640d336d0d911e958a6008311a9d] | committer: Michael Niedermayer

avdevice/dshow: Remove NULL check on pin

The pointer is used before the check

Fixes: CID1591884 Dereference before null check

Sponsored-by: Sovereign Tech Fund
Reviewed-by: Roger Pack <rogerdpack at gmail.com>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=989e11acb65e640d336d0d911e958a6008311a9d
---

 libavdevice/dshow.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c
index 4581f9405c..403e56fe13 100644
--- a/libavdevice/dshow.c
+++ b/libavdevice/dshow.c
@@ -432,8 +432,8 @@ dshow_get_device_media_types(AVFormatContext *avctx, enum dshowDeviceType devtyp
             IEnumMediaTypes_Release(types);
         if (p)
             IKsPropertySet_Release(p);
-        if (pin)
-            IPin_Release(pin);
+
+        IPin_Release(pin);
     }
 
     IEnumPins_Release(pins);



More information about the ffmpeg-cvslog mailing list