[FFmpeg-cvslog] avfilter/af_aresample: Cleanup on av_channel_layout_copy() failure

Michael Niedermayer git at videolan.org
Mon Jul 8 00:39:39 EEST 2024


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Mon Jun 10 21:24:47 2024 +0200| [7a0ea15c7afb8abd823303b9a525cc5e6572f199] | committer: Michael Niedermayer

avfilter/af_aresample: Cleanup on av_channel_layout_copy() failure

Fixes: CID1503078 Resource leak

Sponsored-by: Sovereign Tech Fund
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7a0ea15c7afb8abd823303b9a525cc5e6572f199
---

 libavfilter/af_aresample.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libavfilter/af_aresample.c b/libavfilter/af_aresample.c
index d6bd77beb3..8ff2fe5973 100644
--- a/libavfilter/af_aresample.c
+++ b/libavfilter/af_aresample.c
@@ -195,8 +195,11 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *insamplesref)
     av_frame_copy_props(outsamplesref, insamplesref);
     outsamplesref->format                = outlink->format;
     ret = av_channel_layout_copy(&outsamplesref->ch_layout, &outlink->ch_layout);
-    if (ret < 0)
+    if (ret < 0) {
+        av_frame_free(&outsamplesref);
+        av_frame_free(&insamplesref);
         return ret;
+    }
     outsamplesref->sample_rate           = outlink->sample_rate;
 
     if(insamplesref->pts != AV_NOPTS_VALUE) {



More information about the ffmpeg-cvslog mailing list