[FFmpeg-cvslog] avutil/timecode: Avoid fps overflow in av_timecode_get_smpte_from_framenum()

Michael Niedermayer git at videolan.org
Tue Dec 24 04:45:24 EET 2024


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Sun Dec 22 00:28:21 2024 +0100| [6ba33b50f51b17eef0449f20b3524f174dc9c3cc] | committer: Michael Niedermayer

avutil/timecode: Avoid fps overflow in av_timecode_get_smpte_from_framenum()

Fix from c94875471e3ba3dc396c6919ff3ec9b14539cd71

Found-by: Youngjae Choi <youngjaechoi at korea.ac.kr>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=6ba33b50f51b17eef0449f20b3524f174dc9c3cc
---

 libavutil/timecode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libavutil/timecode.c b/libavutil/timecode.c
index f40a10eb38..f454466f97 100644
--- a/libavutil/timecode.c
+++ b/libavutil/timecode.c
@@ -61,8 +61,8 @@ uint32_t av_timecode_get_smpte_from_framenum(const AVTimecode *tc, int framenum)
         framenum = av_timecode_adjust_ntsc_framenum2(framenum, tc->fps);
     ff = framenum % fps;
     ss = framenum / fps      % 60;
-    mm = framenum / (fps*60) % 60;
-    hh = framenum / (fps*3600) % 24;
+    mm = framenum / (fps*60LL) % 60;
+    hh = framenum / (fps*3600LL) % 24;
     return av_timecode_get_smpte(tc->rate, drop, hh, mm, ss, ff);
 }
 



More information about the ffmpeg-cvslog mailing list