[FFmpeg-cvslog] x86/ac3dsp: clear the upper 32 bits for input arguments where needed

James Almer git at videolan.org
Mon Apr 8 19:46:39 EEST 2024


ffmpeg | branch: master | James Almer <jamrial at gmail.com> | Mon Apr  8 13:44:05 2024 -0300| [b0ef9e35e80990b0ba03dd724a6d41cccba100b1] | committer: James Almer

x86/ac3dsp: clear the upper 32 bits for input arguments where needed

Fixes checkasm on win64.

Signed-off-by: James Almer <jamrial at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b0ef9e35e80990b0ba03dd724a6d41cccba100b1
---

 libavcodec/x86/ac3dsp.asm | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/libavcodec/x86/ac3dsp.asm b/libavcodec/x86/ac3dsp.asm
index 0ba980aa7b..21f59708b7 100644
--- a/libavcodec/x86/ac3dsp.asm
+++ b/libavcodec/x86/ac3dsp.asm
@@ -43,7 +43,7 @@ SECTION .text
 
 %macro AC3_EXPONENT_MIN 0
 cglobal ac3_exponent_min, 3, 4, 2, exp, reuse_blks, expn, offset
-    shl  reuse_blksq, 8
+    shl  reuse_blksd, 8
     jz .end
     LOOP_ALIGN
 .nextexp:
@@ -57,7 +57,7 @@ cglobal ac3_exponent_min, 3, 4, 2, exp, reuse_blks, expn, offset
     jae .nextblk
     mova      [expq], m0
     add         expq, mmsize
-    sub        expnq, mmsize
+    sub        expnd, mmsize
     jg .nextexp
 .end:
     RET
@@ -71,7 +71,7 @@ AC3_EXPONENT_MIN
 %undef LOOP_ALIGN
 
 ;-----------------------------------------------------------------------------
-; void ff_float_to_fixed24(int32_t *dst, const float *src, unsigned int len)
+; void ff_float_to_fixed24(int32_t *dst, const float *src, size_t len)
 ;-----------------------------------------------------------------------------
 
 INIT_XMM sse2
@@ -217,6 +217,7 @@ cglobal ac3_compute_mantissa_size, 1, 2, 4, mant_cnt, sum
 
 %macro AC3_EXTRACT_EXPONENTS 0
 cglobal ac3_extract_exponents, 3, 3, 4, exp, coef, len
+    movsxdifnidn lenq, lend
     add     expq, lenq
     lea    coefq, [coefq+4*lenq]
     neg     lenq



More information about the ffmpeg-cvslog mailing list