[FFmpeg-cvslog] fftools/ffmpeg: drop an obsolete hack
Anton Khirnov
git at videolan.org
Mon May 22 18:11:58 EEST 2023
ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Tue May 16 19:12:07 2023 +0200| [5fa00b38e6627578a95af9ed0cc6cd441f0903c6] | committer: Anton Khirnov
fftools/ffmpeg: drop an obsolete hack
This special handling for decoder flushing has not been needed since
af1761f7b5, as the filtergraph actually is drained after that commit.
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=5fa00b38e6627578a95af9ed0cc6cd441f0903c6
---
fftools/ffmpeg.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 9d554e2fb0..49313edebc 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -1418,17 +1418,6 @@ static int process_input_packet(InputStream *ist, const AVPacket *pkt, int no_eo
if (!got_output)
break;
- // During draining, we might get multiple output frames in this loop.
- // ffmpeg.c does not drain the filter chain on configuration changes,
- // which means if we send multiple frames at once to the filters, and
- // one of those frames changes configuration, the buffered frames will
- // be lost. This can upset certain FATE tests.
- // Decode only 1 frame per call on EOF to appease these FATE tests.
- // The ideal solution would be to rewrite decoding to use the new
- // decoding API in a better way.
- if (!pkt)
- break;
-
repeating = 1;
}
More information about the ffmpeg-cvslog
mailing list