[FFmpeg-cvslog] avformat/hls: fail on probing non hls/m3u8 file extensions

Michael Niedermayer git at videolan.org
Sat May 6 01:26:36 EEST 2023


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Wed May  3 13:08:35 2023 +0200| [6b1f68ccb04d791f0250e05687c346a99ff47ea1] | committer: Michael Niedermayer

avformat/hls: fail on probing non hls/m3u8 file extensions

Its unexpected that a .avi or other "standard" file turns into a playlist.
The goal of this patch is to avoid this unexpected behavior and possible
privacy or security differences.

Reviewed-by: Steven Liu <lingjiujianke at gmail.com>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=6b1f68ccb04d791f0250e05687c346a99ff47ea1
---

 libavformat/hls.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/libavformat/hls.c b/libavformat/hls.c
index 8a96a37ff9..11e345b280 100644
--- a/libavformat/hls.c
+++ b/libavformat/hls.c
@@ -2532,8 +2532,15 @@ static int hls_probe(const AVProbeData *p)
 
     if (strstr(p->buf, "#EXT-X-STREAM-INF:")     ||
         strstr(p->buf, "#EXT-X-TARGETDURATION:") ||
-        strstr(p->buf, "#EXT-X-MEDIA-SEQUENCE:"))
+        strstr(p->buf, "#EXT-X-MEDIA-SEQUENCE:")) {
+
+        if (!av_match_ext(p->filename, "m3u8,hls,m3u")) {
+            av_log(NULL, AV_LOG_ERROR, "Not detecting m3u8/hls with non standard extension\n");
+            return 0;
+        }
+
         return AVPROBE_SCORE_MAX;
+    }
     return 0;
 }
 



More information about the ffmpeg-cvslog mailing list