[FFmpeg-cvslog] avcodec/aacdec_template: Fix undefined signed interger operations
Michael Niedermayer
git at videolan.org
Sun Jul 23 19:12:46 EEST 2023
ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Mon Apr 24 18:21:28 2023 +0200| [87f76d3bee083d33707ed2cb459507186e32fc12] | committer: Michael Niedermayer
avcodec/aacdec_template: Fix undefined signed interger operations
Fixed: signed integer overflow: -2 * -1085502286 cannot be represented in type 'int'
Fixed: 57986/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-5123651145170944
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=87f76d3bee083d33707ed2cb459507186e32fc12
---
libavcodec/aacdec_template.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c
index 2385ea58b0..e8dcd460a0 100644
--- a/libavcodec/aacdec_template.c
+++ b/libavcodec/aacdec_template.c
@@ -2856,8 +2856,8 @@ static void imdct_and_windowing_eld(AACContext *ac, SingleChannelElement *sce)
ac->mdct512_fn(ac->mdct512, buf, in, sizeof(INTFLOAT));
for (i = 0; i < n; i+=2) {
- buf[i + 0] = -(USE_FIXED + 1)*buf[i + 0];
- buf[i + 1] = (USE_FIXED + 1)*buf[i + 1];
+ buf[i + 0] = -(int)(USE_FIXED + 1U)*buf[i + 0];
+ buf[i + 1] = (int)(USE_FIXED + 1U)*buf[i + 1];
}
// Like with the regular IMDCT at this point we still have the middle half
// of a transform but with even symmetry on the left and odd symmetry on
More information about the ffmpeg-cvslog
mailing list