[FFmpeg-cvslog] lavf/mux: clarify log messages when choosing oformat fails
Anton Khirnov
git at videolan.org
Tue Apr 4 12:48:25 EEST 2023
ffmpeg | branch: master | Anton Khirnov <anton at khirnov.net> | Thu Mar 30 11:23:34 2023 +0200| [1d3f7178aee8a4aee8fcea8ba5d03db22e18ba20] | committer: Anton Khirnov
lavf/mux: clarify log messages when choosing oformat fails
Current log messages talk about 'suitable' output formats. This is
confusing, because it suggests that some formats are suitable, while
others are not, which is not the case.
Also, suggest possible user actions when format cannot be guessed from a
filename.
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=1d3f7178aee8a4aee8fcea8ba5d03db22e18ba20
---
libavformat/mux.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/libavformat/mux.c b/libavformat/mux.c
index 0bc9b6b87d..415bd3948f 100644
--- a/libavformat/mux.c
+++ b/libavformat/mux.c
@@ -102,7 +102,7 @@ int avformat_alloc_output_context2(AVFormatContext **avctx, const AVOutputFormat
if (format) {
oformat = av_guess_format(format, NULL, NULL);
if (!oformat) {
- av_log(s, AV_LOG_ERROR, "Requested output format '%s' is not a suitable output format\n", format);
+ av_log(s, AV_LOG_ERROR, "Requested output format '%s' is not known.\n", format);
ret = AVERROR(EINVAL);
goto error;
}
@@ -110,8 +110,10 @@ int avformat_alloc_output_context2(AVFormatContext **avctx, const AVOutputFormat
oformat = av_guess_format(NULL, filename, NULL);
if (!oformat) {
ret = AVERROR(EINVAL);
- av_log(s, AV_LOG_ERROR, "Unable to find a suitable output format for '%s'\n",
- filename);
+ av_log(s, AV_LOG_ERROR,
+ "Unable to choose an output format for '%s'; "
+ "use a standard extension for the filename or specify "
+ "the format manually.\n", filename);
goto error;
}
}
More information about the ffmpeg-cvslog
mailing list