[FFmpeg-cvslog] avformat/icodec: Check nb_pal
Michael Niedermayer
git at videolan.org
Mon Sep 26 01:24:45 EEST 2022
ffmpeg | branch: release/4.4 | Michael Niedermayer <michael at niedermayer.cc> | Sat Sep 17 23:15:56 2022 +0200| [b9b148ef87541b0eb699cb0baa861e262c9e8943] | committer: Michael Niedermayer
avformat/icodec: Check nb_pal
Fixes: signed integer overflow: 538976288 * 4 cannot be represented in type 'int'
Fixes: 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_ICO_fuzzer-6690068904935424
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Peter Ross <pross at xvid.org>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit db73ae0dc114aa6fae08e69f977944f056a24995)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b9b148ef87541b0eb699cb0baa861e262c9e8943
---
libavformat/icodec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/icodec.c b/libavformat/icodec.c
index 93179bb41e..b321ad6007 100644
--- a/libavformat/icodec.c
+++ b/libavformat/icodec.c
@@ -203,6 +203,9 @@ static int read_packet(AVFormatContext *s, AVPacket *pkt)
AV_WL32(buf + 32, image->nb_pal);
}
+ if (image->nb_pal > INT_MAX / 4 - 14 - 40)
+ return AVERROR_INVALIDDATA;
+
AV_WL32(buf - 4, 14 + 40 + image->nb_pal * 4);
AV_WL32(buf + 8, AV_RL32(buf + 8) / 2);
}
More information about the ffmpeg-cvslog
mailing list