[FFmpeg-cvslog] fftools/ffmpeg_opt: Fix leak of options when parsing options fails

Andreas Rheinhardt git at videolan.org
Wed May 4 21:30:01 EEST 2022


ffmpeg | branch: release/3.4 | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Fri Feb 28 22:06:29 2020 +0100| [6f6036146d5808f4663d7e6e1b614ea23b8f2592] | committer: Michael Niedermayer

fftools/ffmpeg_opt: Fix leak of options when parsing options fails

Fixes #8094.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>
Reviewed-by: Paul B Mahol <onemda at gmail.com>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit 21265f42ecb265debe9fec1dbfd0cb7de5a8aefb)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=6f6036146d5808f4663d7e6e1b614ea23b8f2592
---

 fftools/ffmpeg_opt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c
index dcfaa06926..6aed8b65d8 100644
--- a/fftools/ffmpeg_opt.c
+++ b/fftools/ffmpeg_opt.c
@@ -3275,6 +3275,7 @@ static int open_files(OptionGroupList *l, const char *inout,
         if (ret < 0) {
             av_log(NULL, AV_LOG_ERROR, "Error parsing options for %s file "
                    "%s.\n", inout, g->arg);
+            uninit_options(&o);
             return ret;
         }
 



More information about the ffmpeg-cvslog mailing list