[FFmpeg-cvslog] avformat/mov: Non overflowing ambisonic order check
Michael Niedermayer
git at videolan.org
Tue Jun 14 17:50:50 EEST 2022
ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Fri Mar 25 22:47:26 2022 +0100| [9274fb25324cc7676d3464b5248739166926c6a7] | committer: Michael Niedermayer
avformat/mov: Non overflowing ambisonic order check
Fixes: signed integer overflow: 536870913 * 536870913 cannot be represented in type 'int'
Fixes: 45862/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-4730373768085504
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=9274fb25324cc7676d3464b5248739166926c6a7
---
libavformat/mov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index f8248ab65b..3ec0ea2361 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -7381,7 +7381,7 @@ static int mov_read_SA3D(MOVContext *c, AVIOContext *pb, MOVAtom atom)
}
channel_count = avio_rb32(pb);
- if (channel_count != (ambisonic_order + 1) * (ambisonic_order + 1)) {
+ if (ambisonic_order < 0 || channel_count != (ambisonic_order + 1LL) * (ambisonic_order + 1LL)) {
av_log(c->fc, AV_LOG_ERROR,
"Invalid number of channels (%d / %d)\n",
channel_count, ambisonic_order);
More information about the ffmpeg-cvslog
mailing list