[FFmpeg-cvslog] avcodec/ttmlenc: Deduplicate ttml_default_namespacing string

Andreas Rheinhardt git at videolan.org
Sat Jul 30 23:26:07 EEST 2022


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Fri Jul 29 08:43:55 2022 +0200| [879eed5555b2d1f185bd4998631be21b1417874e] | committer: Andreas Rheinhardt

avcodec/ttmlenc: Deduplicate ttml_default_namespacing string

String literals are allowed to be deduplicated (and toolchains
are already capable of doing so), yet the same is not allowed
for named arrays (even when they contain strings). Therefore
use a const char *const pointing to an unnamed string literal
for ttml_default_namespacing.

Reviewed-by: Jan Ekström <jeebjp at gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=879eed5555b2d1f185bd4998631be21b1417874e
---

 libavcodec/ttmlenc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/ttmlenc.h b/libavcodec/ttmlenc.h
index 467f35c7a6..654ca0ee4d 100644
--- a/libavcodec/ttmlenc.h
+++ b/libavcodec/ttmlenc.h
@@ -25,7 +25,7 @@
 #define TTMLENC_EXTRADATA_SIGNATURE "lavc-ttmlenc"
 #define TTMLENC_EXTRADATA_SIGNATURE_SIZE (sizeof(TTMLENC_EXTRADATA_SIGNATURE) - 1)
 
-static const char ttml_default_namespacing[] =
+static const char *const ttml_default_namespacing =
 "  xmlns=\"http://www.w3.org/ns/ttml\"\n"
 "  xmlns:ttm=\"http://www.w3.org/ns/ttml#metadata\"\n"
 "  xmlns:tts=\"http://www.w3.org/ns/ttml#styling\"\n"



More information about the ffmpeg-cvslog mailing list