[FFmpeg-cvslog] fftools/objpool: Don't use return with expression when returning void

Andreas Rheinhardt git at videolan.org
Sat Jul 23 23:43:44 EEST 2022


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Sat Jul 23 18:16:21 2022 +0200| [8136ab8e768b3341929f98412071d492fa729a06] | committer: Andreas Rheinhardt

fftools/objpool: Don't use return with expression when returning void

Using tail calls with functions returning void is forbidden
(C99/C11 6.8.6.4: "A return statement with an expression shall not appear
in a function whose return type is void.") GCC emits a warning
because of this when using -pedantic: "ISO C forbids ‘return’ with
expression, in function returning void"

Reviewed-by: Hendrik Leppkes <h.leppkes at gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8136ab8e768b3341929f98412071d492fa729a06
---

 fftools/objpool.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fftools/objpool.c b/fftools/objpool.c
index b1561ecd69..87237cf724 100644
--- a/fftools/objpool.c
+++ b/fftools/objpool.c
@@ -101,11 +101,11 @@ static void *alloc_frame(void)
 
 static void reset_packet(void *obj)
 {
-    return av_packet_unref(obj);
+    av_packet_unref(obj);
 }
 static void reset_frame(void *obj)
 {
-    return av_frame_unref(obj);
+    av_frame_unref(obj);
 }
 
 static void free_packet(void **obj)



More information about the ffmpeg-cvslog mailing list