[FFmpeg-cvslog] avcodec/opus_silk: Remove wrong size information in function declaration

Andreas Rheinhardt git at videolan.org
Wed Jan 12 02:51:08 EET 2022


ffmpeg | branch: release/4.4 | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Mon Sep 13 14:38:50 2021 +0200| [edaf8c961510ec7a4d83fdbd4b0986ae67ee1357] | committer: Andreas Rheinhardt

avcodec/opus_silk: Remove wrong size information in function declaration

silk_lsp2poly()'s declaration contained arrays with array sizes;
yet these array sizes exceeded the number of actually accessed array
elements (which is related to another parameter) and this leads to
-Wstringop-overflow= warnings from GCC 11, because the arrays provided
by callers are only large enough for the actually used elements.

So replace the incorrect array sizes with comments containing
the correct array sizes. Given that these sizes are not compile-time
constants, they can only be communicated via a comment.

Reported by Paul B Mahol.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>
(cherry picked from commit 4b154743163ffbe3fdc50759c0c55dc854636488)

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=edaf8c961510ec7a4d83fdbd4b0986ae67ee1357
---

 libavcodec/opus_silk.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libavcodec/opus_silk.c b/libavcodec/opus_silk.c
index 913053c5e2..8523b55ada 100644
--- a/libavcodec/opus_silk.c
+++ b/libavcodec/opus_silk.c
@@ -198,7 +198,8 @@ static inline int silk_is_lpc_stable(const int16_t lpc[16], int order)
     }
 }
 
-static void silk_lsp2poly(const int32_t lsp[16], int32_t pol[16], int half_order)
+static void silk_lsp2poly(const int32_t lsp[/* 2 * half_order - 1 */],
+                          int32_t pol[/* half_order + 1 */], int half_order)
 {
     int i, j;
 



More information about the ffmpeg-cvslog mailing list