[FFmpeg-cvslog] avformat/cafdec: Do not store empty keys in read_info_chunk()

Michael Niedermayer git at videolan.org
Mon Apr 18 19:06:49 EEST 2022


ffmpeg | branch: release/3.2 | Michael Niedermayer <michael at niedermayer.cc> | Sat Mar 19 23:36:22 2022 +0100| [f7dbbbdaf0b2cc36cd74b70ea3d8b924d3b5d2c3] | committer: Michael Niedermayer

avformat/cafdec: Do not store empty keys in read_info_chunk()

Fixes: Timeout
Fixes: 45543/clusterfuzz-testcase-minimized-ffmpeg_dem_CAF_fuzzer-5684953164152832

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
(cherry picked from commit 7ec28e1d4cef723485f50f7a08859752b79b570c)
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=f7dbbbdaf0b2cc36cd74b70ea3d8b924d3b5d2c3
---

 libavformat/cafdec.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c
index f23cf50640..3d9c48eaf8 100644
--- a/libavformat/cafdec.c
+++ b/libavformat/cafdec.c
@@ -235,6 +235,8 @@ static void read_info_chunk(AVFormatContext *s, int64_t size)
         char value[1024];
         avio_get_str(pb, INT_MAX, key, sizeof(key));
         avio_get_str(pb, INT_MAX, value, sizeof(value));
+        if (!*key)
+            continue;
         av_dict_set(&s->metadata, key, value, 0);
     }
 }



More information about the ffmpeg-cvslog mailing list