[FFmpeg-cvslog] avcodec/exr: export any unknown header string variable to metadata

[Paul B Mahol]

ffmpeg | branch: master | Paul B Mahol <onemda at gmail.com> | Tue Feb 16 14:37:26 2021 +0100| [8d209eb33c3ae900e913c6645603dfde435c59c1] | committer: Paul B Mahol

avcodec/exr: export any unknown header string variable to metadata

And properly skip preview type in header.

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8d209eb33c3ae900e913c6645603dfde435c59c1
---

 libavcodec/exr.c | 41 ++++++++++++++++++++++++++++++++++++-----
 1 file changed, 36 insertions(+), 5 deletions(-)

diff --git a/libavcodec/exr.c b/libavcodec/exr.c
index 1ae6012ec4..cacdff5774 100644
--- a/libavcodec/exr.c
+++ b/libavcodec/exr.c
@@ -1337,7 +1337,7 @@ static int decode_header(EXRContext *s, AVFrame *frame)
 {
     AVDictionary *metadata = NULL;
     GetByteContext *gb = &s->gb;
-    int magic_number, version, i, flags;
+    int magic_number, version, flags;
     int layer_match = 0;
     int ret;
     int dup_channels = 0;
@@ -1731,6 +1731,18 @@ static int decode_header(EXRContext *s, AVFrame *frame)
                 strncmp("tiledimage", key, var_size))
                 return AVERROR_PATCHWELCOME;
 
+            continue;
+        } else if ((var_size = check_header_variable(s, "preview",
+                                                     "preview", 16)) >= 0) {
+            uint32_t pw = bytestream2_get_le32(gb);
+            uint32_t ph = bytestream2_get_le32(gb);
+            int64_t psize = 4LL * pw * ph;
+
+            if (psize >= bytestream2_get_bytes_left(gb))
+                return AVERROR_INVALIDDATA;
+
+            bytestream2_skip(gb, psize);
+
             continue;
         }
 
@@ -1742,11 +1754,30 @@ static int decode_header(EXRContext *s, AVFrame *frame)
         }
 
         // Process unknown variables
-        for (i = 0; i < 2; i++) // value_name and value_type
-            while (bytestream2_get_byte(gb) != 0);
+        {
+            uint8_t name[256] = { 0 };
+            uint8_t type[256] = { 0 };
+            uint8_t value[256] = { 0 };
+            int i = 0, size;
+
+            while (bytestream2_get_bytes_left(gb) > 0 &&
+                   bytestream2_peek_byte(gb) && i < 255) {
+                name[i++] = bytestream2_get_byte(gb);
+            }
 
-        // Skip variable length
-        bytestream2_skip(gb, bytestream2_get_le32(gb));
+            bytestream2_skip(gb, 1);
+            i = 0;
+            while (bytestream2_get_bytes_left(gb) > 0 &&
+                   bytestream2_peek_byte(gb) && i < 255) {
+                type[i++] = bytestream2_get_byte(gb);
+            }
+            bytestream2_skip(gb, 1);
+            size = bytestream2_get_le32(gb);
+
+            bytestream2_get_buffer(gb, value, FFMIN(sizeof(value) - 1, size));
+            if (!strcmp(type, "string"))
+                av_dict_set(&metadata, name, value, 0);
+        }
     }
 
     if (s->compression == EXR_UNKN) {