[FFmpeg-cvslog] avcodec/libx264: Don't unnecessarily add in-band extradata

[Andreas Rheinhardt]

ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Mon Dec 20 18:08:36 2021 +0100| [155dcfe2e20b5a934310dd7561383b2c978c382d] | committer: Andreas Rheinhardt

avcodec/libx264: Don't unnecessarily add in-band extradata

The check here is meant to check for whether avcintra-class option
(default value -1) has been set; yet it checks for the x264_param_t
value where 0 is the default value (treated as "no avcintra-mode"
by x264). This meant that in-band extradata has been added unnecessarily
when using global headers; furthermore, the first output packet
had two x264 SEIs.

Reviewed-by: Limin Wang <lance.lmwang at gmail.com>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=155dcfe2e20b5a934310dd7561383b2c978c382d
---

 libavcodec/libx264.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
index 5f62c7b1d8..2b680abf21 100644
--- a/libavcodec/libx264.c
+++ b/libavcodec/libx264.c
@@ -944,7 +944,7 @@ static av_cold int X264_init(AVCodecContext *avctx)
 
 #if X264_BUILD >= 142
     /* Separate headers not supported in AVC-Intra mode */
-    if (x4->params.i_avcintra_class >= 0)
+    if (x4->avcintra_class >= 0)
         x4->params.b_repeat_headers = 1;
 #endif