[FFmpeg-cvslog] avfilter/vf_transpose: fix un-checked potential memory allocation failure
Wu Jianhua
git at videolan.org
Fri Dec 10 18:04:54 EET 2021
ffmpeg | branch: master | Wu Jianhua <jianhua.wu at intel.com> | Thu Dec 9 17:36:52 2021 +0800| [ceeff7ae8d918cd54a9b1c8deb85184da53f1250] | committer: Lynne
avfilter/vf_transpose: fix un-checked potential memory allocation failure
Signed-off-by: Wu Jianhua <jianhua.wu at intel.com>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=ceeff7ae8d918cd54a9b1c8deb85184da53f1250
---
libavfilter/vf_transpose.c | 15 ++++++++++++---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/libavfilter/vf_transpose.c b/libavfilter/vf_transpose.c
index f9f0d70cd5..b964daeee3 100644
--- a/libavfilter/vf_transpose.c
+++ b/libavfilter/vf_transpose.c
@@ -328,6 +328,7 @@ static int filter_slice(AVFilterContext *ctx, void *arg, int jobnr,
static int filter_frame(AVFilterLink *inlink, AVFrame *in)
{
+ int err = 0;
AVFilterContext *ctx = inlink->dst;
TransContext *s = ctx->priv;
AVFilterLink *outlink = ctx->outputs[0];
@@ -339,10 +340,13 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
out = ff_get_video_buffer(outlink, outlink->w, outlink->h);
if (!out) {
- av_frame_free(&in);
- return AVERROR(ENOMEM);
+ err = AVERROR(ENOMEM);
+ goto fail;
}
- av_frame_copy_props(out, in);
+
+ err = av_frame_copy_props(out, in);
+ if (err < 0)
+ goto fail;
if (in->sample_aspect_ratio.num == 0) {
out->sample_aspect_ratio = in->sample_aspect_ratio;
@@ -356,6 +360,11 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
FFMIN(outlink->h, ff_filter_get_nb_threads(ctx)));
av_frame_free(&in);
return ff_filter_frame(outlink, out);
+
+fail:
+ av_frame_free(&in);
+ av_frame_free(&out);
+ return err;
}
#define OFFSET(x) offsetof(TransContext, x)
More information about the ffmpeg-cvslog
mailing list