[FFmpeg-cvslog] avfilter/graphdump: Don't silently truncate channel layout string

Andreas Rheinhardt git at videolan.org
Fri Aug 27 19:27:24 EEST 2021


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Thu Aug 26 12:36:33 2021 +0200| [48348cd4aba9cdc5504e8cc7ad1562be192f61ba] | committer: Andreas Rheinhardt

avfilter/graphdump: Don't silently truncate channel layout string

64B are not enough any more.

Reviewed-by: Nicolas George <george at nsup.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=48348cd4aba9cdc5504e8cc7ad1562be192f61ba
---

 libavfilter/graphdump.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/libavfilter/graphdump.c b/libavfilter/graphdump.c
index 22b2e21559..cf3296550c 100644
--- a/libavfilter/graphdump.c
+++ b/libavfilter/graphdump.c
@@ -30,7 +30,6 @@
 static int print_link_prop(AVBPrint *buf, AVFilterLink *link)
 {
     char *format;
-    char layout[64];
     AVBPrint dummy_buffer;
 
     if (!buf) {
@@ -47,11 +46,11 @@ static int print_link_prop(AVBPrint *buf, AVFilterLink *link)
             break;
 
         case AVMEDIA_TYPE_AUDIO:
-            av_get_channel_layout_string(layout, sizeof(layout),
-                                         link->channels, link->channel_layout);
             format = av_x_if_null(av_get_sample_fmt_name(link->format), "?");
-            av_bprintf(buf, "[%dHz %s:%s]",
-                       (int)link->sample_rate, format, layout);
+            av_bprintf(buf, "[%dHz %s:",
+                       (int)link->sample_rate, format);
+            av_bprint_channel_layout(buf, link->channels, link->channel_layout);
+            av_bprint_chars(buf, ']', 1);
             break;
 
         default:



More information about the ffmpeg-cvslog mailing list