[FFmpeg-cvslog] avfilter/vf_find_rect: Don't make frame writable unnecessarily

Andreas Rheinhardt git at videolan.org
Mon Aug 16 00:16:07 EEST 2021


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at outlook.com> | Sun Aug  1 22:48:09 2021 +0200| [c8b1c9f97a20ed0a172e9a6acd36a4ac55243a22] | committer: Andreas Rheinhardt

avfilter/vf_find_rect: Don't make frame writable unnecessarily

AVFrame.metadata is always owned by its AVFrame, it is not shared
in the first place, so one does not need to make the frame writable
to modify it.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at outlook.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=c8b1c9f97a20ed0a172e9a6acd36a4ac55243a22
---

 libavfilter/vf_find_rect.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/libavfilter/vf_find_rect.c b/libavfilter/vf_find_rect.c
index c0c210d9ef..5e45d77a03 100644
--- a/libavfilter/vf_find_rect.c
+++ b/libavfilter/vf_find_rect.c
@@ -225,8 +225,6 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *in)
 
     snprintf(buf, sizeof(buf), "%f", best_score);
 
-    av_frame_make_writable(in);
-
     av_dict_set_int(&in->metadata, "lavfi.rect.w", foc->obj_frame->width, 0);
     av_dict_set_int(&in->metadata, "lavfi.rect.h", foc->obj_frame->height, 0);
     av_dict_set_int(&in->metadata, "lavfi.rect.x", best_x, 0);



More information about the ffmpeg-cvslog mailing list