[FFmpeg-cvslog] avformat/wvdec: Check rate for overflow
Michael Niedermayer
git at videolan.org
Mon Sep 21 13:02:56 EEST 2020
ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Sun Sep 20 20:53:31 2020 +0200| [688c1175ba91d0477cc461e5bfda210d6659a3b8] | committer: Michael Niedermayer
avformat/wvdec: Check rate for overflow
Fixes: signed integer overflow: 6000 * -2147483648 cannot be represented in type 'int'
Fixes: 25700/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-6578316302352384
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=688c1175ba91d0477cc461e5bfda210d6659a3b8
---
libavformat/wvdec.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavformat/wvdec.c b/libavformat/wvdec.c
index b9fc6a59f9..7a5997c1ee 100644
--- a/libavformat/wvdec.c
+++ b/libavformat/wvdec.c
@@ -79,8 +79,9 @@ static int wv_read_block_header(AVFormatContext *ctx, AVIOContext *pb)
{
WVContext *wc = ctx->priv_data;
int ret;
- int rate, rate_x, bpp, chan;
+ int rate, bpp, chan;
uint32_t chmask, flags;
+ unsigned rate_x;
wc->pos = avio_tell(pb);
@@ -192,7 +193,7 @@ static int wv_read_block_header(AVFormatContext *ctx, AVIOContext *pb)
if (id & 0x40)
avio_skip(pb, 1);
}
- if (rate == -1) {
+ if (rate == -1 || rate * (uint64_t)rate_x >= INT_MAX) {
av_log(ctx, AV_LOG_ERROR,
"Cannot determine custom sampling rate\n");
return AVERROR_INVALIDDATA;
More information about the ffmpeg-cvslog
mailing list