[FFmpeg-cvslog] avformat/dashdec: Don't leave representation in inconsistent state on error

Andreas Rheinhardt git at videolan.org
Mon Sep 21 05:59:54 EEST 2020


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Mon Sep  7 20:32:51 2020 +0200| [01a4c3596942dad396834fea155173590687c59d] | committer: Andreas Rheinhardt

avformat/dashdec: Don't leave representation in inconsistent state on error

This currently doesn't cause any trouble, because the only caller did
not clean up the representation upon error at all; but fixing this is
a prerequisite for doing so.

Reviewed-by: Steven Liu <lq at chinaffmpeg.org>
Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=01a4c3596942dad396834fea155173590687c59d
---

 libavformat/dashdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c
index f81b323d96..d84da16dbd 100644
--- a/libavformat/dashdec.c
+++ b/libavformat/dashdec.c
@@ -627,7 +627,7 @@ static int parse_manifest_segmenturlnode(AVFormatContext *s, struct representati
                                                      initialization_val);
 
             if (!rep->init_section->url) {
-                av_free(rep->init_section);
+                av_freep(&rep->init_section);
                 xmlFree(initialization_val);
                 xmlFree(range_val);
                 return AVERROR(ENOMEM);



More information about the ffmpeg-cvslog mailing list