[FFmpeg-cvslog] avcodec/vble: Don't free buffer known to be NULL

Andreas Rheinhardt git at videolan.org
Thu Sep 17 01:10:58 EEST 2020


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Sun Sep 13 03:52:39 2020 +0200| [a265e6604eb411316ec7ec91ba1bfaa37c71ef2d] | committer: Andreas Rheinhardt

avcodec/vble: Don't free buffer known to be NULL

Freeing a buffer allocated in the VBLE decoder's init function
is the only thing the decoder's close function does and this implies
that it is unnecessary to call it in case said allocation fails. Yet
this is what has been done.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a265e6604eb411316ec7ec91ba1bfaa37c71ef2d
---

 libavcodec/vble.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libavcodec/vble.c b/libavcodec/vble.c
index c48c13127a..2cddd550b1 100644
--- a/libavcodec/vble.c
+++ b/libavcodec/vble.c
@@ -197,7 +197,6 @@ static av_cold int vble_decode_init(AVCodecContext *avctx)
 
     if (!ctx->val) {
         av_log(avctx, AV_LOG_ERROR, "Could not allocate values buffer.\n");
-        vble_decode_close(avctx);
         return AVERROR(ENOMEM);
     }
 



More information about the ffmpeg-cvslog mailing list