[FFmpeg-cvslog] avformat/subviewerdec: fail on AV_NOPTS_VALUE

Michael Niedermayer git at videolan.org
Thu Oct 15 19:45:10 EEST 2020


ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Sun Jul 19 17:13:10 2020 +0200| [b7f51428b1c73ab5840485ce537ce098a85d0881] | committer: Michael Niedermayer

avformat/subviewerdec: fail on AV_NOPTS_VALUE

Such values are not supported by ff_subtitles_queue*

Fixes: signed integer overflow: 10 - -9223372036854775808 cannot be represented in type 'long'
Fixes: 24193/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5714901855895552

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=b7f51428b1c73ab5840485ce537ce098a85d0881
---

 libavformat/subviewerdec.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavformat/subviewerdec.c b/libavformat/subviewerdec.c
index fdca3a4820..5c2fe676f1 100644
--- a/libavformat/subviewerdec.c
+++ b/libavformat/subviewerdec.c
@@ -148,6 +148,10 @@ static int subviewer_read_header(AVFormatContext *s)
             new_event = 1;
             pos = avio_tell(s->pb);
         } else if (*line) {
+            if (pts_start == AV_NOPTS_VALUE) {
+                res = AVERROR_INVALIDDATA;
+                goto end;
+            }
             if (!new_event) {
                 sub = ff_subtitles_queue_insert(&subviewer->q, "\n", 1, 1);
                 if (!sub) {



More information about the ffmpeg-cvslog mailing list