[FFmpeg-cvslog] avcodec/speedhq: Don't pretend reading DC can fail

Andreas Rheinhardt git at videolan.org
Tue Oct 13 00:08:36 EEST 2020


ffmpeg | branch: master | Andreas Rheinhardt <andreas.rheinhardt at gmail.com> | Mon Oct 12 04:08:07 2020 +0200| [7b6acfa68f034c6e2cf2455dbc0f96d959ef36b0] | committer: Andreas Rheinhardt

avcodec/speedhq: Don't pretend reading DC can fail

It can't, because the tables used don't have any loose ends. This also
fixes a bug in the only caller of decode_dc_le(): It didn't check the
return value.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=7b6acfa68f034c6e2cf2455dbc0f96d959ef36b0
---

 libavcodec/speedhq.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/libavcodec/speedhq.c b/libavcodec/speedhq.c
index b834b79f28..64758164de 100644
--- a/libavcodec/speedhq.c
+++ b/libavcodec/speedhq.c
@@ -168,10 +168,6 @@ static inline int decode_dc_le(GetBitContext *gb, int component)
     } else {
         code = get_vlc2(gb, ff_dc_chroma_vlc_le.table, DC_VLC_BITS, 2);
     }
-    if (code < 0) {
-        av_log(NULL, AV_LOG_ERROR, "invalid dc code at\n");
-        return 0xffff;
-    }
     if (!code) {
         diff = 0;
     } else {



More information about the ffmpeg-cvslog mailing list