[FFmpeg-cvslog] avfilter/af_adelay: Check sscanf() return value

Limin Wang git at videolan.org
Fri May 1 01:37:16 EEST 2020


ffmpeg | branch: master | Limin Wang <lance.lmwang at gmail.com> | Sun Mar 29 08:08:05 2020 +0800| [f441fadbcffa32b71470220b522d4971a774e760] | committer: Limin Wang

avfilter/af_adelay: Check sscanf() return value

Reviewed-by: Michael Niedermayer <michael at niedermayer.cc>
Signed-off-by: Limin Wang <lance.lmwang at gmail.com>

> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=f441fadbcffa32b71470220b522d4971a774e760
---

 libavfilter/af_adelay.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/libavfilter/af_adelay.c b/libavfilter/af_adelay.c
index c9647771f2..6ac81c2a3e 100644
--- a/libavfilter/af_adelay.c
+++ b/libavfilter/af_adelay.c
@@ -155,7 +155,10 @@ static int config_input(AVFilterLink *inlink)
         ret = av_sscanf(arg, "%d%c", &d->delay, &type);
         if (ret != 2 || type != 'S') {
             div = type == 's' ? 1.0 : 1000.0;
-            av_sscanf(arg, "%f", &delay);
+            if (av_sscanf(arg, "%f", &delay) != 1) {
+                av_log(ctx, AV_LOG_ERROR, "Invalid syntax for delay.\n");
+                return AVERROR(EINVAL);
+            }
             d->delay = delay * inlink->sample_rate / div;
         }
 



More information about the ffmpeg-cvslog mailing list