[FFmpeg-cvslog] avcodec/huffyuvdec: Test vertical coordinate more often
Michael Niedermayer
git at videolan.org
Sat Jun 6 01:51:24 EEST 2020
ffmpeg | branch: master | Michael Niedermayer <michael at niedermayer.cc> | Fri Jun 5 22:05:27 2020 +0200| [a1223ddc5692772198a02600ecff2545f32b37be] | committer: Michael Niedermayer
avcodec/huffyuvdec: Test vertical coordinate more often
Fixes: out of array access
Fixes: 22892/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HYMT_fuzzer-5135996772679680.fuzz
Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Reviewed-by: Paul B Mahol <onemda at gmail.com>
Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=a1223ddc5692772198a02600ecff2545f32b37be
---
libavcodec/huffyuvdec.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/libavcodec/huffyuvdec.c b/libavcodec/huffyuvdec.c
index 0ee7ec3917..e713b91e4d 100644
--- a/libavcodec/huffyuvdec.c
+++ b/libavcodec/huffyuvdec.c
@@ -928,12 +928,16 @@ static int decode_slice(AVCodecContext *avctx, AVFrame *p, int height,
left= left_prediction(s, p->data[plane], s->temp[0], w, 0);
y = 1;
+ if (y >= h)
+ break;
/* second line is left predicted for interlaced case */
if (s->interlaced) {
decode_plane_bitstream(s, w, plane);
left = left_prediction(s, p->data[plane] + p->linesize[plane], s->temp[0], w, left);
y++;
+ if (y >= h)
+ break;
}
lefttop = p->data[plane][0];
@@ -1045,6 +1049,8 @@ static int decode_slice(AVCodecContext *avctx, AVFrame *p, int height,
}
cy = y = 1;
+ if (y >= height)
+ break;
/* second line is left predicted for interlaced case */
if (s->interlaced) {
@@ -1057,6 +1063,8 @@ static int decode_slice(AVCodecContext *avctx, AVFrame *p, int height,
}
y++;
cy++;
+ if (y >= height)
+ break;
}
/* next 4 pixels are left predicted too */
More information about the ffmpeg-cvslog
mailing list